[vlc-devel] [PATCH v2 09/13] contrib: add an extract phase to extract all the sources that will be built

Rémi Denis-Courmont remi at remlab.net
Thu Jul 9 16:36:13 CEST 2020


Le jeudi 9 juillet 2020, 15:38:36 EEST Steve Lhomme a écrit :
> On 2020-07-07 19:10, Rémi Denis-Courmont wrote:
> > If you don't build them, there's no way to match them with the build
> > content.
> 
> Why is that ? You pick the hash VLC was built on, bootstrap contribs for
> the target you use and extract the sources. It should match the sources
> from the build you have.

Well duh, that extracts the sources in the VLC tree at that time, *not* the 
sources in the prebuilt contribs. If you want matching sources and binaries, 
you BUILD THEM.

> The only inconsistencies you might get when extracting is if some code
> depends on a different compiler. But little by little we're removing
> patches that depend on the build target and apply no matter what. Having
> patches upstreamed also helps in that direction.

No because:

> > Besides there *cannot* be distinction between extraction and build. Some
> > packages literally don't have separate steps. And even those that do,
> > can and typically do have generated sources.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list