[vlc-devel] [PATCH v2 09/13] contrib: add an extract phase to extract all the sources that will be built

[Steve Lhomme]

On 2020-07-09 16:36, Rémi Denis-Courmont wrote:
> Le jeudi 9 juillet 2020, 15:38:36 EEST Steve Lhomme a écrit :
>> On 2020-07-07 19:10, Rémi Denis-Courmont wrote:
>>> If you don't build them, there's no way to match them with the build
>>> content.
>>
>> Why is that ? You pick the hash VLC was built on, bootstrap contribs for
>> the target you use and extract the sources. It should match the sources
>> from the build you have.
> 
> Well duh, that extracts the sources in the VLC tree at that time, *not* the
> sources in the prebuilt contribs. If you want matching sources and binaries,
> you BUILD THEM.

I don't know any Windows user who builds their own VLC. The VLC they use 
is the one we build (rightfully) and it's not built using packaged 
prebuilt contribs. But even though, it's still using the same script in 
both cases which extracts and builds the contribs in a deterministic 
location in the VLC tree.

With just a VLC git HASH you can tell exactly where and what the source 
files of contribs are.

>> The only inconsistencies you might get when extracting is if some code
>> depends on a different compiler. But little by little we're removing
>> patches that depend on the build target and apply no matter what. Having
>> patches upstreamed also helps in that direction.
> 
> No because:
> 
>>> Besides there *cannot* be distinction between extraction and build. Some
>>> packages literally don't have separate steps. And even those that do,
>>> can and typically do have generated sources.

Can you name 2 contribs that don't have this step ?