[vlc-devel] [PATCH v2 09/13] contrib: add an extract phase to extract all the sources that will be built

[Steve Lhomme]

On 2020-07-09 16:41, Rémi Denis-Courmont wrote:
> Le jeudi 9 juillet 2020, 17:36:13 EEST Rémi Denis-Courmont a écrit :
>> Le jeudi 9 juillet 2020, 15:38:36 EEST Steve Lhomme a écrit :
>>> On 2020-07-07 19:10, Rémi Denis-Courmont wrote:
>>>> If you don't build them, there's no way to match them with the build
>>>> content.
>>>
>>> Why is that ? You pick the hash VLC was built on, bootstrap contribs for
>>> the target you use and extract the sources. It should match the sources
>>> from the build you have.
>>
>> Well duh, that extracts the sources in the VLC tree at that time, *not* the
>> sources in the prebuilt contribs. If you want matching sources and binaries,
>> you BUILD THEM.
> 
> Not to mention that the decade (and a half) old recommendation is to checkout
> and build separately any library that you hack on together with VLC - if only
> so that you have the VCS working and the latest upstream changes.
> 
> That is definitely not something that contribs is meant and designed, nor even
> remotely practical and suited for.

It's not because for 15 years something was not practical/used that it's 
going to stay like that forever. In fact we have reached he time where 
it works and we should do it.

> And then the prebuilt contribs aren't normally built for debug either.

Prebuilt or not prebuilt, this has nothing to do with what we're talking 
about. But in fact you could use prebuilt contribs *and* want the 
sources they correspond to on the size without having to build 
everything. So that's a very good use "make extract" in contribs.

The builds do what we tell them to. If we decide we want symbols in 
prebuilt and in release builds, we can do it. PDBs will make it easier 
for Windows because they don't have to be shipped in the same package.