[vlc-devel] [PATCH v2 08/13] contrib: use consistent names between the package name and the extracted dir

[Steve Lhomme]

On 2020-07-10 14:12, Rémi Denis-Courmont wrote:
> Le jeudi 9 juillet 2020, 15:33:00 EEST Steve Lhomme a écrit :
>> The fact that all extracted targets can be addressed via $(PKG) is an
>> added bonus to this change.
> 
> No. That can't work ever since there is mostly but *not* exactly a 1:1 mapping
> between packages and directories.

You always say "can't work" when people come up with patches that work. 
That makes a lot of your patch reviews less trustworthy.

>> Right now the inconsistencies make it
>> impossible. And I don't see a good reason not to have consistency.
> 
> There is a consistent rule that is mostly followed. Again, if there are cases

"*consistent* rule *mostly* followed". Thanks for the oxomoron.

> not following the rule, you can fix them, but that's not what this patch seems
> to do.

There is no written rule nor any consistent rule. The closest rule there 
is to use a the target name, the same as the .target name. This is 
exactly what I followed and what allows to address PKGS just like you 
can address .PKGS and .sum-PKGS which is otherwise impossible since 
there is no easy correspondence between the tarball name and the 
.package and .sum-package name. So I am bring a missing consistency in 
this patch.

And since you mention some churn in the contrib directories, it's better 
*NOT* to rely on the tarball names ever but use our consistent names. So 
in the future if a target completely changes their output name, we still 
have our own consistency.