[vlc-devel] [PATCH 3/3] extras: ci: add apple tvos arm64 job

[Alexandre Janniaux]

Hi,

On Tue, Jul 14, 2020 at 11:29:45AM +0300, Konstantin Pavlov wrote:
> On Tue, Jul 14, 2020 at 10:13:41AM +0200, Alexandre Janniaux wrote:
> > Test compilation for apple tvOS, which has the particularity to need
> > apple bitcode when compiling in order to ship it.
> > ---
> >  extras/ci/gitlab-ci.yml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/extras/ci/gitlab-ci.yml b/extras/ci/gitlab-ci.yml
> > index 8e6fc7cb6f4..24868e47c72 100644
> > --- a/extras/ci/gitlab-ci.yml
> > +++ b/extras/ci/gitlab-ci.yml
> > @@ -70,6 +70,13 @@ variables:
> >          MAKEFLAGS: -j4
> >          SDKNAME: iphonesimulator
> >
> > +.variables-tvos-arm64: &variables-tvos-arm64
> > +        VLC_PATH: /Users/videolanci/sandbox/bin
> > +        HOST_ARCH: arm64
> > +        TRIPLET: $HOST_ARCH-apple-appletvos
> > +        MAKEFLAGS: -j4
>
> I'm actually not sure why we have this number hardcoded in .gitlab-ci.yml.
>
> Can we have it set up in the build scripts just like every other build
> does?  I'm fine with a separate patchset for that change, this one LGTM.

It seems a good idea to configure it directly in the worker instead,
or use the default value in the buildscript, which is currently
`number of core+1`. Is it the expected number of core the worker
is expected to use?

Regards,
--
Alexandre Janniaux
Videolabs