[vlc-devel] [PATCH] filter: add a pf_close callback

Alexandre Janniaux ajanni at videolabs.io
Fri Jul 17 11:24:25 CEST 2020


For now it's conservative, it calls pf_close() if it is set
before calling filter's deactivate if there is one.

One can port any filter from deactivate to pf_close by setting
pf_close and using set_callback instead of set_callbacks, without
modifying the other filter.

What we need to keep in mind is that module_unneed is calling
vlc_objres_clear() which we cannot call outside of the core.

Alexandre Janniaux

On Fri, Jul 17, 2020 at 10:55:18AM +0200, Francois Cartegnie wrote:
> Le 17/07/2020 à 10:30, Alexandre Janniaux a écrit :
> > Having a pf_close callback associated to the object instead of the
> > module allows a filter to wrap any other filter transparently.
> >
> > In particular, this is a central piece in order to expose other
> > capability kind of filter as a filter_t video filter using a wrapping
> > filter_t video filter implementation.
> > ---
> Does it need to change the whole (activate deactivate) for (open close
> filter) ?
> --
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list