[vlc-devel] [PATCH] filter: add a pf_close callback

[Alexandre Janniaux]

Hi,

I first switched filter_t to an op structure, which is painful too
to bring at once (~80 filters), but I reached issues when it comes
with function having multiple different pf_filter callback (especially,
video converter) and didn't come up with a decision between not doing
this, doing memory allocation of the vtable or a generic pf_filter
switching the real filter functions.

The last one seems reasonable, but is a bit ugly in comparison with
the current implementation. But the goal of not switching all filters
right now is especially to avoid doing this job twice yes.

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Jul 17, 2020 at 04:53:15PM +0300, Rémi Denis-Courmont wrote:
> Le perjantaina 17. heinäkuuta 2020, 11.30.56 EEST Alexandre Janniaux a écrit :
> > Having a pf_close callback associated to the object instead of the
> > module allows a filter to wrap any other filter transparently.
>
> Yes, but shouldn't filter_t first be switched to an op structure?
>
> --
> レミ・デニ-クールモン
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel