[vlc-devel] [PATCH 06/10] vout: control: do not wait until the deadline for incoming commands
remi at remlab.net
Fri Jul 17 17:08:15 CEST 2020
Le perjantaina 17. heinäkuuta 2020, 16.56.24 EEST Rémi Denis-Courmont a écrit
> Le perjantaina 17. heinäkuuta 2020, 14.50.49 EEST Steve Lhomme a écrit :
> > Either there are pending commands (filters and mouse handling) and we
> > apply
> > them before processing the next picture. Or there is none and they will be
> > handled with the next frame.
> The deadline served effectively two purposes:
> - prioritise blitting over handling control requests,
> - pace the thread loop.
> I can guess from the commit message that you want to remove the priority
> corner-case (and I don't have any strong opinion on that). But there should
> be some modicum of explanation how pacing works from thereon.
Actually, I missed the most important reason for this, to avoid waiting for
the next picture date to handle events.
Of course, it is less important now that there are so few control events left,
but it seems still necessary so long as there are in fact some of them left,
> Patches 1-5 look ok, though the control loop is a dying horse being beat.
More information about the vlc-devel