[vlc-devel] [PATCH 4/6] aout: reflect channel count from requested stereo-mode

[Thomas Guillem]

On Fri, Jul 17, 2020, at 18:39, Rémi Denis-Courmont wrote:
> Le perjantaina 17. heinäkuuta 2020, 18.04.12 EEST Thomas Guillem a écrit :
> > On Fri, Jul 17, 2020, at 15:51, Rémi Denis-Courmont wrote:
> > > Le torstaina 16. heinäkuuta 2020, 15.25.33 EEST Thomas Guillem a écrit :
> > > > This will fix weird case when the user request a mono/stereo/headphone
> > > > mode
> > > > but the output is configured for > stereo channels.
> > > 
> > > The intended behaviour was to ignore the setting for non-stereo inputs,
> > > since it makes no sense for non-stereo input - not to force downmix to
> > > stereo.
> > Sorry, I  struggle to parse this sentence.
> 
> The stereo mode variable must be ignored for non-stereo inputs. It always was 
> always working and intended to work that way since I implemented it - and even 
> before that in its earlier incarnation.

It makes sense.

I propose the following then

 - "stereo-mode" is only used for left/right/mono/reverse and enabled with stereo inputs.

 - add a "mix-mode" option for the following case:
  - 7.1 : 7.1, 5.1, 4.0, 2.0, headphones (binauraliser or dolby)
  - 5.1: 5.1, 4.0, 2.0, headphones (binauraliser or dolby)
  - 4.0: 4.0, 2.0, headphones (binauraliser or dolby)
  - 2.0: 2.0, headphones (binauraliser or dolby)

The "mix-mode" can change the aout start format, and introduce an audio filter for the conversion.


> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel