[vlc-devel] [PATCH] apple: build: ensure core_count is valid

[Marvin Scholz]

LGTM

On 21 Jul 2020, at 13:47, Alexandre Janniaux wrote:

> When compiling on linux with set -x, the script fails because
> machdep.cpu.core_count doesn't exist. Use 0 core in that case and rely
> on the value set by -j/--jobs.
> ---
>  extras/package/apple/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/extras/package/apple/build.sh b/extras/package/apple/build.sh
> index 1b112e84651..209ec280700 100755
> --- a/extras/package/apple/build.sh
> +++ b/extras/package/apple/build.sh
> @@ -89,8 +89,8 @@ VLC_USE_PREBUILT_CONTRIBS=0
>  # User-provided URL from where to fetch contribs, empty
>  # for the default chosen by contrib system
>  VLC_PREBUILT_CONTRIBS_URL=${VLC_PREBUILT_CONTRIBS_URL:-""}
> -# The number of cores to compile on
> -CORE_COUNT=$(sysctl -n machdep.cpu.core_count)
> +# The number of cores to compile on, or 0 + 1 if not darwin
> +CORE_COUNT=$(sysctl -n machdep.cpu.core_count || echo 0)
>  let VLC_USE_NUMBER_OF_CORES=$CORE_COUNT+1
>  # whether to disable debug mode (the default) or not
>  VLC_DISABLE_DEBUG=0
> -- 
> 2.27.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel