[vlc-devel] [PATCH 2/4] Add cross-compilation targets for Rust contribs

[Kartik Ohri]

On Wed, Jul 22, 2020 at 12:10 AM Martin Storsjö <martin at martin.st> wrote:

> On Tue, 21 Jul 2020, rustyc wrote:
>
> > ---
> > contrib/src/main.mak | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> > index 3119a39875..c8d7df4202 100644
> > --- a/contrib/src/main.mak
> > +++ b/contrib/src/main.mak
> > @@ -440,6 +440,36 @@ else
> > MESON = meson $(MESONFLAGS)
> > endif
> >
> > +ifdef HAVE_WIN32
> > +RUST_TARGET = i686-pc-windows-gnu
> > +else ifdef HAVE_WIN64
> > +RUST_TARGET = x86_64-pc-windows-gnu
>
> This is incorrectly assuming that windows implies x86. HAVE_WIN* only
> implies the bitness, but it can still be armv7 and aarch64 in addition to
> i686 and x86_64.
>
> Yes, that is true. I had added it this way by looking at the various
triplets used by VLC (from the gitlab-ci.yml). I didn't specify armv7 and
aarch64 because I thought they aren't used. But it is not future proof in
any way, I'll fix this.

> // Martin
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200722/bb860cf2/attachment.html>