[vlc-devel] [PATCH 06/19] image: move documentation from src/misc/image.c to image.c

[Kartik Ohri]

On Thu, Jul 23, 2020 at 6:57 PM Marvin Scholz <epirat07 at gmail.com> wrote:

> Commit message should probably say vlc_image.h instead of image.c?
>
Yes, that's a typo. Will fix it :)

>
> On 23 Jul 2020, at 15:18, Kartik Ohri wrote:
>
> > From: rustyc <amcap1712 at gmail.com>
> >
> > ---
> >  include/vlc_image.h | 9 +++++++++
> >  src/misc/image.c    | 8 --------
> >  2 files changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/vlc_image.h b/include/vlc_image.h
> > index 250974f368..7d967a43d9 100644
> > --- a/include/vlc_image.h
> > +++ b/include/vlc_image.h
> > @@ -60,8 +60,17 @@ struct image_handler_t
> >      picture_fifo_t *outfifo;
> >  };
> >
> > +/**
> > + * Create an image_handler_t instance
> > + *
> > + */
> >  VLC_API image_handler_t * image_HandlerCreate( vlc_object_t * )
> > VLC_USED;
> >  #define image_HandlerCreate( a ) image_HandlerCreate( VLC_OBJECT(a) )
> > +
> > +/**
> > + * Delete the image_handler_t instance
> > + *
> > + */
> >  VLC_API void image_HandlerDelete( image_handler_t * );
> >
> >  #define image_Read( a, b, c, d ) a->pf_read( a, b, c, d )
> > diff --git a/src/misc/image.c b/src/misc/image.c
> > index faa05d9b01..dbebdfb4fe 100644
> > --- a/src/misc/image.c
> > +++ b/src/misc/image.c
> > @@ -86,10 +86,6 @@ vlc_fourcc_t image_Ext2Fourcc( const char * );
> >  /*static const char *Fourcc2Ext( vlc_fourcc_t );*/
> >
> >  #undef image_HandlerCreate
> > -/**
> > - * Create an image_handler_t instance
> > - *
> > - */
> >  image_handler_t *image_HandlerCreate( vlc_object_t *p_this )
> >  {
> >      image_handler_t *p_image = calloc( 1, sizeof(image_handler_t) );
> > @@ -109,10 +105,6 @@ image_handler_t *image_HandlerCreate(
> > vlc_object_t *p_this )
> >      return p_image;
> >  }
> >
> > -/**
> > - * Delete the image_handler_t instance
> > - *
> > - */
> >  void image_HandlerDelete( image_handler_t *p_image )
> >  {
> >      if( !p_image ) return;
> > --
> > 2.25.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200723/a31f14de/attachment.html>