[vlc-devel] [PATCH 6/7] contrib: gmp: disable asm for macOS aarch64 for now

[Marvin Scholz]

On 29 Jul 2020, at 21:49, Martin Storsjö wrote:

> On Wed, 29 Jul 2020, Marvin Scholz wrote:
>
>> While it builds fine, the build is actually broken and produces 
>> errors
>> when trying to link the library.
>> ---
>> contrib/src/gmp/rules.mak | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/contrib/src/gmp/rules.mak b/contrib/src/gmp/rules.mak
>> index a79b2bc955..499cb3b4d7 100644
>> --- a/contrib/src/gmp/rules.mak
>> +++ b/contrib/src/gmp/rules.mak
>> @@ -25,6 +25,12 @@ GMP_CONF += --disable-assembly
>> endif
>> endif
>>
>> +ifdef HAVE_MACOSX
>> +ifeq ($(ARCH),aarch64)
>> +GMP_CONF += --disable-assembly
>> +endif
>> +endif
>> +
>> $(TARBALLS)/gmp-$(GMP_VERSION).tar.bz2:
>> 	$(call download_pkg,$(GMP_URL),gmp)
>
> This patch kind of makes 2/7 ("gmp: patch arm64 asm ...") redundant as 
> it's not necessarily enough on its own.
>

Indeed, will remove it.

> // Martin