[vlc-devel] [PATCH 4/7] contrib: bluray: disable building jar for aarch64 macOS

[Marvin Scholz]

On 30 Jul 2020, at 7:52, Steve Lhomme wrote:

> Shouldn't the libluray deal with platform with no JAVA by itself ? I'm 
> sure VLC can read bluray's on a machine with no JAVA.
> If the issue is compiling it should also detect there's no javac. I've 
> compiled VLC plenty of time without a JAVA compiler.
>
> In other words, what is the issue you are solving here ?
>

It does not, I am not sure how you did it, but libbluray errors out for 
me
in this case, unless building the jar is explicitly disabled.

> On 2020-07-29 13:28, Marvin Scholz wrote:
>> ---
>>   contrib/src/bluray/rules.mak | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/contrib/src/bluray/rules.mak 
>> b/contrib/src/bluray/rules.mak
>> index 597975af83..7a56a64d7d 100644
>> --- a/contrib/src/bluray/rules.mak
>> +++ b/contrib/src/bluray/rules.mak
>> @@ -41,6 +41,14 @@ ifndef WITH_OPTIMIZATION
>>   BLURAY_CONF += --disable-optimizations
>>   endif
>>  +ifdef HAVE_MACOSX
>> +ifeq ($(ARCH),aarch64)
>> +# There is no Java yet for this OS/arch,
>> +# so let's disable it for now
>> +BLURAY_CONF += --disable-bdjava-jar
>> +endif
>> +endif
>> +
>>   $(TARBALLS)/libbluray-$(BLURAY_VERSION).tar.bz2:
>>   	$(call download,$(BLURAY_URL))
>>  -- 
>> 2.24.3 (Apple Git-128)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel