[vlc-devel] [PATCH 1/7] contrib: Do not hardcode 32/64 bit

[Marvin Scholz]

On 30 Jul 2020, at 7:48, Steve Lhomme wrote:

> From the gcc doc:
> For darwin only the -m64 option turns off the -fno-pic and 
> -mdynamic-no-pic options
>
> Not sure it's OK to remove it. You may limit the -m32 use to i686/i386 
> arch instead. But maybe modern gcc doesn't need any of this and just 
> relies on the arch target...
>

We do not build with GCC on macOS, I could not find any such note for 
clang.
Additionally macOS at least for 64bit always uses PIC regardless of any 
such
option, afaik.

> On 2020-07-29 13:28, Marvin Scholz wrote:
>> This was probably needed at the time of 32/64bit switchover but there
>> should be no need to do this at all anymore. Additionally it breaks
>> compiling for any non-x86_64 macOS that is not 32bit.
>> ---
>>   contrib/src/main.mak | 9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 3119a39875..e6c722d7cc 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -131,16 +131,7 @@ endif
>>    ifdef HAVE_MACOSX
>>   EXTRA_CXXFLAGS += -stdlib=libc++
>> -ifeq ($(ARCH),x86_64)
>> -EXTRA_CFLAGS += -m64
>> -EXTRA_LDFLAGS += -m64
>> -else
>> -EXTRA_CFLAGS += -m32
>> -EXTRA_LDFLAGS += -m32
>> -endif
>> -
>>   XCODE_FLAGS += -arch $(ARCH)
>> -
>>   endif
>>    CCAS=$(CC) -c
>> -- 
>> 2.24.3 (Apple Git-128)
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel