[vlc-devel] [PATCH 01/19] vout: kms: don't use a custom picture destroy

[Steve Lhomme]

On 2020-07-30 14:59, Alexandre Janniaux wrote:
> Hi,
> 
> On Thu, Jul 30, 2020 at 02:27:48PM +0200, Steve Lhomme wrote:
>> On 2020-07-30 14:26, Alexandre Janniaux wrote:
>>> Hi,
>>>
>>> Missing initialization for picture_resource_t.
>>
>> The planes are still initialized as before. Only the callback and p_sys are
>> removed.
> 
> No, like I mentionned in previous posts:
> 
>>>> -    picture_resource_t rsc = {
>>>> -        .p_sys = psys,
>>>> -        .pf_destroy = CustomDestroyPicture,
>>>> -    };
> 
> This is a designated initializer, it initializes omitted
> fields to the initial value of the bss / like other objects
> that have static storage duration, which is zero in all
> reasonable crt0. But...
> 
>>>> +    picture_resource_t rsc = {};
> 
> ...this initializer doesn't exist in C, it's a GNU extension,
> and it generates warnings.

ok