[vlc-devel] [PATCH 07/19] picture: allow NULL gc callback

Steve Lhomme robux4 at ycbcr.xyz
Fri Jul 31 06:27:31 CEST 2020


On 2020-07-30 17:52, Rémi Denis-Courmont wrote:
> Le torstaina 30. heinäkuuta 2020, 15.16.48 EEST Steve Lhomme a écrit :
>> No need to use a dummy one if we don't have to.
> 
> One could equally say that there are no needs to test for NULL if we don't
> have to. I don't see the benefit of this patch unless the goal is to remove the
> callback completely.

Removing the callback is one of the goals. Initializing pictures with no 
picture_gc_t at all is another, bigger benefit. In a lot of cases the 
allocation and deletion is done outside of the picture. We don't need 
boilerplate code doing nothing just to please the API quirks.


More information about the vlc-devel mailing list