[vlc-devel] [PATCH] qt: Fix linking EGL from QtANGLE on windows on i386

[Pierre Lamot]

Great thanks

On 2020-05-30 07:46, Martin Storsjö wrote:
> On Fri, 22 May 2020, Martin Storsjö wrote:
> 
>> On Fri, 22 May 2020, Martin Storsjö wrote:
>> 
>>> Define EGLAPI instead of KHRONOS_STATIC to indicate static linking,
>>> as defining KHRONOS_STATIC surprisingly not only affects linkage, but
>>> also affects the calling convention (normally the EGL functions are
>>> stdcall, but with KHRONOS_STATIC defined, they become cdecl).
>>> ---
>>> Alternatively, we could tweak the Qt patch for adding support for
>>> KHRONOS_STATIC, to not affect __stdcall. I commented on this upstream
>>> at 
>>> https://github.com/KhronosGroup/EGL-Registry/commit/94ba8ee876206364cf45a9bc08b8db5a52cb9543#r39362613,
>>> let's see if there's any response, because to me, it looks like 
>>> that's
>>> the actual original bug.
>> 
>> FWIW, I sent a fix in this form upstream as well, 
>> https://github.com/KhronosGroup/EGL-Registry/pull/106, let's see how 
>> it goes...
> 
> This got merged, so fixing it in vlc by backporting that upstream fix
> into our existing contribs patch instead.
> 
> // Martin
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel