[vlc-devel] [PATCH] configure: link with synchronization library when building for win8+

[Rémi Denis-Courmont]

Le perjantaina 5. kesäkuuta 2020, 12.28.52 EEST Steve Lhomme a écrit :
> That's what should be used when calling WaitOnAddress.
> It's not part of the kernel32.dll anymore.
> 
> https://docs.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-wait
> onaddress ---
>  configure.ac | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 3f6e91a1888f..08e87df41c3e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -266,6 +266,18 @@ case "${host_os}" in
>      ],[
>        AC_DEFINE([_WIN32_WINNT], [0x0601], [Define to '0x0601' for Windows 7
> APIs.]) ])
> +    AC_MSG_CHECKING([if libsynchronization is needed])
> +    AC_PREPROC_IFELSE([AC_LANG_PROGRAM(
> +      [[#if _WIN32_WINNT >= 0x0602
> +       # error building for Win8+ and above
> +       #endif
> +      ]],[[;]])
> +    ],[
> +      AC_MSG_RESULT([no])
> +    ],[
> +      AC_MSG_RESULT([yes])
> +      VLC_ADD_LIBS([libvlccore], [-lsynchronization])
> +    ])

I'm going to guess that 'proper' AC_SEARCH_LIBS will give false positives, but 
I don't see how this is supposed to work for values < 0x602.

>      AC_DEFINE([_WIN32_IE], [0x0600], [Define to '0x0600' for IE 6.0 (and
> shell) APIs.]) AC_DEFINE([UNICODE], [1], [Define to 1 for Unicode (Wide
> Chars) APIs.]) AC_DEFINE([_ISOC99_SOURCE], [1], [Extensions to ISO C89 from
> ISO C99.])


-- 
Rémi Denis-Courmont
http://www.remlab.net/