[vlc-devel] [PATCH 5/6] transcode: video: use i_chroma instead of i_codec

[Alexandre Janniaux]

Hi,

I'm not sure this patch is needed since it should theoretically
be the same logic, or I might add the correct assertion before
to ensure i_chroma = i_codec before.

However, it probably makes more sense to compare chroma given
that we create picture from them now that we have a push
pipeline.

If you agree, I'll probably add more rationale in the patch but
it seemed a good thing to me to discuss this here before as it
is quite confusing to have both at the first place.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Jun 09, 2020 at 06:43:59PM +0200, Alexandre Janniaux wrote:
> ---
>  modules/stream_out/transcode/video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/stream_out/transcode/video.c b/modules/stream_out/transcode/video.c
> index 14282ae864..e94588c978 100644
> --- a/modules/stream_out/transcode/video.c
> +++ b/modules/stream_out/transcode/video.c
> @@ -627,7 +627,7 @@ int transcode_video_process( sout_stream_t *p_stream, sout_stream_id_sys_t *id,
>              /* In case the encoder wasn't open yet, check if we need to add
>               * a converter between last user filter and encoder. */
>              if( !is_encoder_open &&
> -                filter_fmt_out.i_codec != encoder_fmt_in->i_codec )
> +                filter_fmt_out.video.i_chroma != encoder_fmt_in->video.i_chroma )
>              {
>                  if ( !id->p_final_conv_static )
>                      id->p_final_conv_static =
> --
> 2.27.0
>