[vlc-devel] [PATCH 1/6] chroma: chain: suggest *->CVPI conversion

[Alexandre Janniaux]

Hi,

Thanks for your input, that's what I thought too.

Trying to go via CVPI isn't necessarily a bad idea since
it mostly affects the transcode pipeline or video filters
which are both mostly designed for I420 originally, but
it is not future-proof and adds platform-specific code
into generic code.

I'll change it that way,

Regards,
--
Alexandre Janniaux
Videolabs


On Wed, Jun 10, 2020 at 09:22:35PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 9. kesäkuuta 2020, 19.43.55 EEST Alexandre Janniaux a écrit :
> > When generating pictures with VLC_CODEC_CVPX_BGRA as i_chroma, the core
> > will add the following conversion:
> >
> >     CVPB -> BGRA -> I422 -> I420
> >
> > Instead, by hinting that it could use VLC_CODEC_CVPX_I420, we get the
> > following conversion chain:
> >
> >     CVPB -> CVPI -> I420
>
> I don't think that this patch does that. It rather just tries to go via CVPI
> (essentially) always. This does not sound like a very good idea.
>
> You may be better off handling this special case in macOS specific plugins.
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel