[vlc-devel] [PATCH] lib: core: Use vlc_atomic_rc_t for refcounting

[Rémi Denis-Courmont]

Le torstaina 11. kesäkuuta 2020, 14.28.55 EEST Thomas Guillem a écrit :
> Indeed, this instance_lock is useless now (or badly used in the dialog cbs
> case).
> 
> We could just add in the documentation that libvlc_dialog_set_callbacks()
> should be called from the same thread than libvlc_new() and before creating
> any media or media_player.
> 
> So, I'm OK with this patch the and the lock removal.

Well, either add a comment to remove the lock, or remove the lock. But I'd 
rather not merge the patch and forget the lock, even if the patch looks 
correct.

-- 
Реми Дёни-Курмон
http://www.remlab.net/