[vlc-devel] [PATCH] lib: event: add back i_id in media_player_es_changed

[Thomas Guillem]

On Fri, Jun 12, 2020, at 16:52, Rémi Denis-Courmont wrote:
> I don't see the point. It's downstream self-inflicted problem if they use too new VLC 4.0 prerelease.

It breaks VLC's ports CI. It's just temporary to smooth the transition.

> 
> Le 12 juin 2020 12:27:35 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> To keep compability with the old track API since VLC's ports are still using it.
>> 
>> This will be removed when the old track API is removed. include/vlc/libvlc_events.h | 1 +
>>  lib/media_player.c          | 1 +
>>  2 files changed, 2 insertions(+)
>> 
>> diff --git a/include/vlc/libvlc_events.h b/include/vlc/libvlc_events.h
>> index 6c3ea15e9b4..5cd545097e7 100644
>> --- a/include/vlc/libvlc_events.h
>> +++ b/include/vlc/libvlc_events.h
>> @@ -356,6 +356,7 @@ typedef struct libvlc_event_t
>>          struct
>>          {
>>              libvlc_track_type_t i_type;
>> +            int i_id; /**< Deprecated, use psz_id */
>>              /** Call libvlc_media_player_get_track_from_id() to get the track
>>               * description. */
>>              const char *psz_id;
>> diff --git a/lib/media_player.c b/lib/media_player.c
>> index d33a1b5b5cb..79550a271e2 100644
>> --- a/lib/media_player.c
>> +++ b/lib/media_player.c
>> @@ -263,6 +263,7 @@ on_track_list_changed(vlc_player_t *player, enum vlc_player_list_action action,
>>  
>>      event.u.media_player_es_changed.i_type =
>>          track_type_from_cat(track->fmt.i_cat);
>> +    event.u.media_player_es_changed.i_id = vlc_es_id_GetInputId(track->es_id);
>>      event.u.media_player_es_changed.psz_id = vlc_es_id_GetStrId(track->es_id);
>>  
>>      libvlc_event_send(&mp->event_manager, &event);
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200612/e67767c8/attachment.html>