[vlc-devel] [PATCH 12/14] android: utils: remove AWindow SurfaceTexture functions

Thomas Guillem thomas at gllm.fr
Mon Jun 15 13:30:42 CEST 2020


Could you also propose a patch, removing the SurfaceTexture_* foo, in vlc-android ?

On Fri, Jun 12, 2020, at 11:40, Alexandre Janniaux wrote:
> They are not used anymore since we create the SurfaceTexture ourselves.
> ---
>  modules/video_output/android/utils.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/modules/video_output/android/utils.c 
> b/modules/video_output/android/utils.c
> index d458e275772..4272883a18d 100644
> --- a/modules/video_output/android/utils.c
> +++ b/modules/video_output/android/utils.c
> @@ -126,10 +126,6 @@ static struct
>          jmethodID registerNative;
>          jmethodID unregisterNative;
>          jmethodID setVideoLayout;
> -        jmethodID attachToGLContext;
> -        jmethodID detachFromGLContext;
> -        jmethodID waitAndUpdateTexImage;
> -        jmethodID getSurface;
>      } AWindow;
>      struct {
>            jclass clazz;
> @@ -754,16 +750,6 @@ InitJNIFields(JNIEnv *env, vlc_object_t *p_obj, 
> jobject *jobj)
>      GET_METHOD(AWindow.setVideoLayout,
>                 "setVideoLayout", "(IIIIII)V", true);
>  
> -    GET_METHOD(AWindow.attachToGLContext,
> -               "SurfaceTexture_attachToGLContext", "(I)Z", true);
> -    GET_METHOD(AWindow.detachFromGLContext,
> -               "SurfaceTexture_detachFromGLContext", "()V", true);
> -    GET_METHOD(AWindow.waitAndUpdateTexImage,
> -               "SurfaceTexture_waitAndUpdateTexImage", "([F)Z",
> -               true);
> -    GET_METHOD(AWindow.getSurface,
> -               "SurfaceTexture_getSurface", "()Landroid/view/Surface;", true);
> -
>      if ((*env)->RegisterNatives(env, clazz, jni_callbacks, 2) < 0)
>      {
>          msg_Err(p_obj, "RegisterNatives failed");
> -- 
> 2.27.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list