[vlc-devel] [PATCH] qt: fix uninitialized variables in DComp compositor

Pierre Lamot pierre at videolabs.io
Mon Jun 15 17:32:29 CEST 2020


  This was causing crashes when releasing the object after a failed init.
---
 modules/gui/qt/maininterface/compositor_dcomp.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/qt/maininterface/compositor_dcomp.hpp b/modules/gui/qt/maininterface/compositor_dcomp.hpp
index 1d89affa9b..7deaf92127 100644
--- a/modules/gui/qt/maininterface/compositor_dcomp.hpp
+++ b/modules/gui/qt/maininterface/compositor_dcomp.hpp
@@ -59,9 +59,9 @@ private:
     static void window_unset_fullscreen(struct vout_window_t *);
     static void window_set_fullscreen(struct vout_window_t *, const char *id);
 
-    intf_thread_t *m_intf;
+    intf_thread_t *m_intf = nullptr;
 
-    MainInterface* m_rootWindow;
+    MainInterface* m_rootWindow = nullptr;
     std::unique_ptr<CompositorDCompositionUISurface> m_uiSurface;
     vout_window_t *m_window = nullptr;
     std::unique_ptr<MainUI> m_ui;
-- 
2.25.1



More information about the vlc-devel mailing list