[vlc-devel] [PATCH v2] CI: add a UWP libvlc target

[Steve Lhomme]

On 2020-06-16 14:50, Hugo Beauzée-Luyssen wrote:
> On Tue, Jun 16, 2020, at 2:44 PM, Steve Lhomme wrote:
>> ---
>>   extras/ci/gitlab-ci.yml | 14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/extras/ci/gitlab-ci.yml b/extras/ci/gitlab-ci.yml
>> index 9dd56a64bc67..41f665f90bd9 100644
>> --- a/extras/ci/gitlab-ci.yml
>> +++ b/extras/ci/gitlab-ci.yml
>> @@ -15,6 +15,7 @@ variables:
>>       VLC_WIN32_IMAGE:
>> registry.videolan.org/vlc-debian-win32:20200602191827
>>       VLC_WIN64_IMAGE:
>> registry.videolan.org/vlc-debian-win64:20200602185103
>>       VLC_WIN_LLVM_IMAGE:
>> registry.videolan.org/vlc-debian-llvm-mingw:20200603153044
>> +    VLC_UWP_LLVM_IMAGE:
>> registry.videolan.org/vlc-debian-llvm-uwp:20200603145315
>>       VLC_DEBIAN_IMAGE:
>> registry.videolan.org/vlc-debian-unstable:20200229201904
>>       VLC_ANDROID_IMAGE:
>> registry.videolan.org/vlc-debian-android:20190717134531
>>       VLC_SNAP_IMAGE:
>> registry.videolan.org/vlc-ubuntu-bionic:20190627090437
>> @@ -113,9 +114,9 @@ variables:
>>           fi
>>           if [ -n "$VLC_PREBUILT_CONTRIBS_URL" ]; then
>>               echo "Building using prebuilt contribs at
>> $VLC_PREBUILT_CONTRIBS_URL"
>> -            extras/package/win32/build.sh -p -a $HOST_ARCH
>> $NIGHTLY_EXTRA_BUILD_FLAGS
>> +            extras/package/win32/build.sh -p -a $HOST_ARCH
>> $NIGHTLY_EXTRA_BUILD_FLAGS $LIBVLC_EXTRA_BUILD_FLAGS
>> $UWP_EXTRA_BUILD_FLAGS
>>           else
>> -            extras/package/win32/build.sh -c -a $HOST_ARCH
>> $NIGHTLY_EXTRA_BUILD_FLAGS
>> +            extras/package/win32/build.sh -c -a $HOST_ARCH
>> $NIGHTLY_EXTRA_BUILD_FLAGS $LIBVLC_EXTRA_BUILD_FLAGS
>> $UWP_EXTRA_BUILD_FLAGS
>>           fi
>>   
>>   win32:
>> @@ -136,6 +137,15 @@ win64-llvm:
>>           name: $VLC_WIN_LLVM_IMAGE
>>       variables: *variables-win64-llvm
>>   
>> +uwp64-libvlc-llvm:
>> +    extends: .win-common
>> +    image:
>> +        name: $VLC_UWP_LLVM_IMAGE
>> +    variables:
>> +        <<: *variables-win64
>> +        LIBVLC_EXTRA_BUILD_FLAGS: -z
>> +        UWP_EXTRA_BUILD_FLAGS: -u -w -x
>> +
>>   .nightly-win-common:
>>       extends: .win-common
>>       only:
>> -- 
>> 2.26.2
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> Hi,
> 
> For UWP I think i686 is a better CI arch, since symbols are mangled, any missing function (mostly because it's forbidden) will result in a hard link error instead of the usual warning about the function not being declared.
> I don't mind having i686 & x86_64 though :) (Or maybe i686 & arm64 ?)

Well, I don't think anybody uses UWP in i686 targets but I see what you 
mean. Is this a target we want to actively maintain ? I can understand 
on 3.0 since we distributed it but for 4.0 I'm not sure.

I'm fine adding arm64 since it's already available in the same Docker.

There's a difference between nightly builds and CI builds to verify 
everything still builds correctly. I think UWP nightlies should have 
x86_64 and maybe arm64. CI builds I don't mind but it would be odd not 
to have the main target (x86_64).