[vlc-devel] [PATCH] CI: add a UWP libvlc target

[Marvin Scholz]

(Resending as last one got lost)

On 11 Jun 2020, at 15:59, Konstantin Pavlov wrote:

> On Thu, Jun 11, 2020 at 03:43:48PM +0200, Steve Lhomme wrote:
>> On 2020-06-11 15:40, Konstantin Pavlov wrote:
>>> Hi Steve,
>>>
>>> On Thu, Jun 11, 2020 at 10:30:34AM +0200, Steve Lhomme wrote:
>>>> +.variables-uwp64-libvlc-llvm: &variables-uwp64-libvlc-llvm
>>>> +        SHORTARCH: win64
>>>> +        HOST_ARCH: x86_64
>>>> +        TRIPLET: $HOST_ARCH-w64-mingw32
>>>> +
>>>>   .variables-macos: &variables-macos
>>>>           VLC_PATH: /Users/videolanci/sandbox/bin
>>>>           VLC_FORCE_KERNELVERSION: 18
>>>> @@ -111,11 +117,17 @@ variables:
>>>>           if [ "${CI_JOB_NAME:0:8}" = "nightly-" ]; then
>>>>               NIGHTLY_EXTRA_BUILD_FLAGS="-i n -l"
>>>>           fi
>>>> +        if [ -z "${CI_JOB_NAME##*-libvlc-*}" ]; then
>>>> +            LIBVLC_EXTRA_BUILD_FLAGS="-z"
>>>> +        fi
>>>> +        if [ -z "${CI_JOB_NAME##*uwp*-*}" ]; then
>>>> +            UWP_EXTRA_BUILD_FLAGS="-u -w -x"
>>>> +        fi
>>>
>>> Hmmm, maybe just put those variables under 
>>> .variables-uwp64-libvlc-llvm?
>>
>> It could be done but since there's a chance we add win32 and arm64 
>> (and
>> maybe arm32) in the future I thought it would be easier to have it 
>> more
>> automatic.
>>
>> Same for libvlc. We may want to generate libvlc only builds for all 
>> sorts of
>> targets.
>
> I understand the reasons behind your approach, keeping file a bit 
> shorter
> and have it more "automatic", especially seeing I did a similar thing 
> for
> nightlies.
>
> However, the issue with nightlies and the reason there is a special
> kludge, is that there is no easy way to merge multiple parents into 
> one
> job while preserving all the variables without overwriting them...
>
> My personal opinion is it's better to be explicit when we can, so I 
> would
> prefer them to be in specific targets.
>
> Maybe someone else well-versed in CI has a good idea?  Marvin?
>

It seems it should be possible to combine variables like this:

https://gitlab.com/gitlab-org/gitlab-foss/-/issues/35953#note_37041648

So maybe we can do that here. I am not really a fan of the if … 
approach
either, as it means less variables are in a common and easy to find
place, and it's hard to read.

> -- 
> VideoLAN, Vice President
> www.videolan.org
> +7 926 165 45 31
> @cryothresh