[vlc-devel] [PATCH] extras: add a script to verify that cherry-pick commits are "properly" formatted

[Steve Lhomme]

On 2020-06-17 14:24, Konstantin Pavlov wrote:
> Hi Steve,
> 
> On Wed, Jun 17, 2020 at 07:59:19AM +0200, Steve Lhomme wrote:
>> On 2020-06-17 7:56, Steve Lhomme wrote:
>>> This is for the 3.0 branch but could be added to 4.0 for later use (and
>>> cherry-pick it in 3.0 since it's not a development specific to 3.0)
>>>
>>> I didnt' find a formalized way to describe modified cherry-picks so I
>>> created one.
>>
>> Also it's not meant to be enforced. It's a nice tool to make sure all your
>> cherry-picks are properly indentifiable (so far changes are not documented
>> and you have to look manually for changes).
>>
>> If we decide to enforce a more formal cherry-pick documentating (in 3.0) the
>> script could be used to check the commits in a merge request.
> 
> Yep.
> 
>>> On 2020-06-17 7:53, Steve Lhomme wrote:
>>>> Cherry picks must:
>>>> - have the (cherry picked from commit <hash>) line
>>>> - have a Signed-off-by: line
> 
> That is a good idea when someone else is backporting your commit, but if
> you are backporting your own, it doesnt make much sense, IMO.

When looking at the git log you can't see who did the backport, but it's 
still possible to know who did it anyway.

I don't check that the Signed-off is by the person who is doing the 
commits but it could be added.