[vlc-devel] [PATCH 1/2] opengl: do not report interop fmt changes

[Alexandre Janniaux]

Hi,

Patchset LGTM. You could reference the commit it's cleaning
from in order to understand why it just removes code.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Jun 17, 2020 at 09:28:49PM +0200, Romain Vimont wrote:
> The interop implementations may edit their copy of input format, in
> particular to handle RGB fallbacks.
>
> These internal changes must not be reported to the core, otherwise it
> would attempt to insert a converter.
> ---
>  modules/video_output/opengl/vout_helper.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/modules/video_output/opengl/vout_helper.c b/modules/video_output/opengl/vout_helper.c
> index 291a916695f1..5e4ef90213af 100644
> --- a/modules/video_output/opengl/vout_helper.c
> +++ b/modules/video_output/opengl/vout_helper.c
> @@ -178,12 +178,6 @@ vout_display_opengl_t *vout_display_opengl_New(video_format_t *fmt,
>       && vout_display_opengl_SetViewpoint(vgl, viewpoint) != VLC_SUCCESS)
>          goto delete_sub_renderer;
>
> -    video_orientation_t orientation = fmt->orientation;
> -    *fmt = vgl->interop->fmt;
> -    /* The orientation is handled by the orientation matrix: from the core
> -     * point of view, it does not change. */
> -    fmt->orientation = orientation;
> -
>      if (subpicture_chromas) {
>          *subpicture_chromas = gl_subpicture_chromas;
>      }
> --
> 2.27.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel