[vlc-devel] [PATCH] contrib: ffmpeg: use -Og in non optimized builds

[Rémi Denis-Courmont]

Lgtm

Le 18 juin 2020 11:31:37 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>It's better than -O0 in some cases, like clang on i686 that gives this
>error:
>
> In file included from libavcodec/h264_cabac.c:46:
>libavcodec/x86/h264_cabac.c:66:9: error: inline assembly requires more
>registers than available
>        "3:                                     \n\t"
>        ^
>1 error generated.
>make[1]: *** [ffbuild/common.mak:59: libavcodec/h264_cabac.o] Error 1
>---
> contrib/src/ffmpeg/rules.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/contrib/src/ffmpeg/rules.mak
>b/contrib/src/ffmpeg/rules.mak
>index 187d513aa14f..d80956da40ac 100644
>--- a/contrib/src/ffmpeg/rules.mak
>+++ b/contrib/src/ffmpeg/rules.mak
>@@ -88,7 +88,7 @@ FFMPEGCONF += --enable-thumb
> endif
> endif
> else
>-FFMPEGCONF += --optflags=-O0
>+FFMPEGCONF += --optflags=-Og
> endif
> 
> ifdef HAVE_CROSS_COMPILE
>-- 
>2.26.2
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200618/f34e0b8c/attachment.html>