[vlc-devel] [PATCH 3.0 15/16] win32: Don't pass the built dll to dlltool when creating the import library

Martin Storsjö martin at martin.st
Fri Jun 19 23:27:06 CEST 2020


The def file generated by the linker is enough input to dlltool;
this doesn't change the output import library at all.

This fixes building with llvm-dlltool, which doesn't support
providing object files/dlls, it only supports reading from a def file
(which these commands already did anyway).

(cherry picked from commit 86d68171643e9c36ef16d4d0e22dcd947a96ad9d)
---
 extras/package/win32/package.mak | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/extras/package/win32/package.mak b/extras/package/win32/package.mak
index 1a4ff8fb4a..c307da804c 100644
--- a/extras/package/win32/package.mak
+++ b/extras/package/win32/package.mak
@@ -32,9 +32,9 @@ package-win-sdk: package-win-install
 	cp -r $(prefix)/lib/pkgconfig "$(win32_destdir)/sdk/lib"
 	cp -rv $(prefix)/lib/libvlc.dll.a "$(win32_destdir)/sdk/lib/libvlc.lib"
 	cp -rv $(prefix)/lib/libvlccore.dll.a "$(win32_destdir)/sdk/lib/libvlccore.lib"
-	$(DLLTOOL) -D libvlc.dll -l "$(win32_destdir)/sdk/lib/libvlc.lib" -d "$(top_builddir)/lib/.libs/libvlc.dll.def" "$(prefix)/bin/libvlc.dll"
+	$(DLLTOOL) -D libvlc.dll -l "$(win32_destdir)/sdk/lib/libvlc.lib" -d "$(top_builddir)/lib/.libs/libvlc.dll.def"
 	echo "INPUT(libvlc.lib)" > "$(win32_destdir)/sdk/lib/vlc.lib"
-	$(DLLTOOL) -D libvlccore.dll -l "$(win32_destdir)/sdk/lib/libvlccore.lib" -d "$(top_builddir)/src/.libs/libvlccore.dll.def" "$(prefix)/bin/libvlccore.dll"
+	$(DLLTOOL) -D libvlccore.dll -l "$(win32_destdir)/sdk/lib/libvlccore.lib" -d "$(top_builddir)/src/.libs/libvlccore.dll.def"
 	echo "INPUT(libvlccore.lib)" > "$(win32_destdir)/sdk/lib/vlccore.lib"
 
 package-win-common: package-win-install package-win-sdk
-- 
2.17.1



More information about the vlc-devel mailing list