[vlc-devel] [PATCH] opengl: renderer: avoid clearing on Open()

[Alexandre Janniaux]

Hi,

I should have added that that it raised issues in macosx
by doing drawing in the Open function of the display while
the drawing buffer wasn't available, which is the original
issue.

I'll add it to the commit message.

Regards,
--
Alexandre Janniaux
Videolabs

On Sat, Jun 20, 2020 at 11:23:44AM +0200, Alexandre Janniaux wrote:
> Ideally, the renderer should never clear at all, but clearing on Open()
> is an unexpected drawing operation when initializing it.
> ---
>  modules/video_output/opengl/renderer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/modules/video_output/opengl/renderer.c b/modules/video_output/opengl/renderer.c
> index 335ca27e484..b49e0ebc791 100644
> --- a/modules/video_output/opengl/renderer.c
> +++ b/modules/video_output/opengl/renderer.c
> @@ -353,7 +353,6 @@ vlc_gl_renderer_New(vlc_gl_t *gl, const struct vlc_gl_api *api,
>      vt->DepthMask(GL_FALSE);
>      vt->Enable(GL_CULL_FACE);
>      vt->ClearColor(0.0f, 0.0f, 0.0f, 1.0f);
> -    vt->Clear(GL_COLOR_BUFFER_BIT);
>
>      vt->GenBuffers(1, &renderer->vertex_buffer_object);
>      vt->GenBuffers(1, &renderer->index_buffer_object);
> --
> 2.27.0
>