[vlc-devel] [PATCH] opengl: renderer: avoid clearing on Open()

[Thomas Guillem]

+1

On Sun, Jun 21, 2020, at 00:11, Romain Vimont wrote:
> LGTM
> 
> On Sat, Jun 20, 2020 at 11:23:44AM +0200, Alexandre Janniaux wrote:
> > Ideally, the renderer should never clear at all, but clearing on Open()
> > is an unexpected drawing operation when initializing it.
> > ---
> >  modules/video_output/opengl/renderer.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/modules/video_output/opengl/renderer.c b/modules/video_output/opengl/renderer.c
> > index 335ca27e484..b49e0ebc791 100644
> > --- a/modules/video_output/opengl/renderer.c
> > +++ b/modules/video_output/opengl/renderer.c
> > @@ -353,7 +353,6 @@ vlc_gl_renderer_New(vlc_gl_t *gl, const struct vlc_gl_api *api,
> >      vt->DepthMask(GL_FALSE);
> >      vt->Enable(GL_CULL_FACE);
> >      vt->ClearColor(0.0f, 0.0f, 0.0f, 1.0f);
> > -    vt->Clear(GL_COLOR_BUFFER_BIT);
> >  
> >      vt->GenBuffers(1, &renderer->vertex_buffer_object);
> >      vt->GenBuffers(1, &renderer->index_buffer_object);
> > -- 
> > 2.27.0
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel