[vlc-devel] [PATCH 2/2] vout: vulkan: add a variety of built-in shaders

[Thomas Guillem]

On Mon, Jun 22, 2020, at 11:23, Romain Vimont wrote:
> On Mon, Jun 22, 2020 at 11:08:44AM +0200, Niklas Haas wrote:
> > On Mon, 22 Jun 2020 09:45:58 +0200, Romain Vimont <rom1v at videolabs.io> wrote:
> > > > +"//!TEXTURE ravu_lut3\n"
> > > > +"//!SIZE 5 648\n"
> > > > +"//!FORMAT rgba16f\n"
> > > > +"//!FILTER NEAREST\n"
> > > > +"1a88533af88e23bb14d5c73afaa0e53ab42022bbcfc4583abb5687bb3fe2283c...
> > > 
> > > For info, what is this hexa string, containing 103682 chars?
> > 
> > It is a hard-coded look-up table of pretrained weights. The source of
> > this shader is https://github.com/bjin/mpv-prescalers, which contains
> > more information about how the weights were trained (and how to train
> > your own, if you really want to - it's a simple linear regression).
> > 
> > For the curious, the weights were trained using a very scientifically
> > collected database of anime movies. :)
> 
> OK, thank you for the explanation :)
> 
> > Do you want me to add this information in the commit message or a
> > comment, or were you merely asking for your own curiosity?
> 
> I was curious, but I guess a comment could be useful.
> 
> (Also, in practice I think it is annoying to have a line with >100k
> columns.)

Indeed, this patch freeze my web client...
Could you split the lines ? Or maybe put it a separate file and include it.

> 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel