[vlc-devel] [PATCH 4/4] package/win32: build.sh: add a -o option to specify where to install vlc

[Steve Lhomme]

On 2020-06-23 17:11, Rémi Denis-Courmont wrote:
> Le tiistaina 23. kesäkuuta 2020, 15.36.50 EEST Steve Lhomme a écrit :
>> On 2020-06-23 14:27, Alexandre Janniaux wrote:
>>> Hi,
>>>
>>> Won't there be any confusion between DESTDIR and --prefix
>>
>> DESTDIR is the --prefix so I don't see the confusion.
> 
> No. DESTDIR is prepended to the prefix, if it is specified.
> 
> For relocatable builds, it's preferable to set the prefix to root.

So,

1/ this patch doesn't do anything with DESTDIR, patches 2 and 3 do. This 
patch can be used regardless of these patches.

2/ I found DESTDIR in the Makefile that is generated when building VLC. 
And that's why it ends up exactly where I expect the .pdb and .lib files 
to be, in line with all the other files installed during "make install". 
I put an example from our Makefile at the end of this email.

3/ I don't think the concept of relocatable builds apply to Windows 
which is the only thing touched by patches 2, 3 and 4. (patch 1 is 
unrelated to all this)


install-libLTLIBRARIES: $(lib_LTLIBRARIES)
	@$(NORMAL_INSTALL)
	@list='$(lib_LTLIBRARIES)'; test -n "$(libdir)" || list=; \
	list2=; for p in $$list; do \
	  if test -f $$p; then \
	    list2="$$list2 $$p"; \
	  else :; fi; \
	done; \
	test -z "$$list2" || { \
	  echo " $(MKDIR_P) '$(DESTDIR)$(libdir)'"; \
	  $(MKDIR_P) "$(DESTDIR)$(libdir)" || exit 1; \
	  echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=install 
$(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 '$(DESTDIR)$(libdir)'"; \
	  $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=install 
$(INSTALL) $(INSTALL_STRIP_FLAG) $$list2 "$(DESTDIR)$(libdir)"; \
	}