[vlc-devel] [PATCH 4/6] microdns: Include the modele in the item name

Alexandre Janniaux ajanni at videolabs.io
Fri Jun 26 17:33:07 CEST 2020


Hi,

Code LGTM but there is a typo in the commit title :)

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Jun 26, 2020 at 05:11:10PM +0200, Hugo Beauzée-Luyssen wrote:
> This can help differenciate devices with similar names and matches
> bonjour's behavior
> ---
>  modules/services_discovery/microdns.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/modules/services_discovery/microdns.c b/modules/services_discovery/microdns.c
> index 3cbd501681..16f23d914c 100644
> --- a/modules/services_discovery/microdns.c
> +++ b/modules/services_discovery/microdns.c
> @@ -521,6 +521,16 @@ new_entries_rd_cb( void *p_this, int i_status, const struct rr_entry *p_entries
>              free( psz_uri );
>              break;
>          }
> +        if( p_srv->renderer.psz_model != NULL )
> +        {
> +            char* psz_name;
> +            if ( asprintf( &psz_name, "%s (%s)", p_srv->psz_device_name,
> +                           p_srv->renderer.psz_model ) > 0 )
> +            {
> +                free( p_srv->psz_device_name );
> +                p_srv->psz_device_name = psz_name;
> +            }
> +        }
>
>          if( strcmp( p_srv->psz_protocol, "chromecast" ) == 0)
>              psz_demux_filter = "cc_demux";
> --
> 2.20.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list