[vlc-devel] [PATCH 22/27] modules: use VLC_PLUGIN_PATH if it exists

[Alexandre Janniaux]

Hi,

We may not need all those samples then, and just reduce
to the one or two that are useful for development, so as
to keep them in the core and compile them as test plugins
like the mock plugin.

Regards,
--
Alexandre Janniaux
Videolabs

On Sat, Jun 27, 2020 at 04:11:49PM +0200, Romain Vimont wrote:
> On Sat, Jun 27, 2020 at 02:43:59PM +0300, Rémi Denis-Courmont wrote:
> > Le lauantaina 27. kesäkuuta 2020, 14.23.28 EEST Romain Vimont a écrit :
> > > On Thu, Jun 25, 2020 at 07:41:11PM +0300, Rémi Denis-Courmont wrote:
> > > > Le torstaina 25. kesäkuuta 2020, 18.17.43 EEST Romain Vimont a écrit :
> > > > > On Thu, Jun 25, 2020 at 05:37:42PM +0300, Rémi Denis-Courmont wrote:
> > > > > > Le torstaina 25. kesäkuuta 2020, 15.23.09 EEST Romain Vimont a écrit :
> > > > > > > Do not overwrite the VLC_PLUGIN_PATH environment variable if it
> > > > > > > exists.
> > > > > >
> > > > > > Overriding is very much done on purpose. Otherwise, it would be
> > > > > > disastrous
> > > > > > when people develop with the variable set and everything in the build
> > > > > > tree
> > > > > > suddently starts failing.
> > > > > >
> > > > > > -1
> > > > >
> > > > > Would it be ok to force VLC_PLUGIN_PATH to "modules:doc" instead of
> > > > > "modules" when the flag is enabled? (or always?)
> > > >
> > > > That's almost as bad - stale plugins causing weird failures in build and
> > > > tests.
> > >
> > > To explore all possibilities, what would you think about adding samples
> > > in modules/samples/ instead of doc/?
> >
> > We already have never installed modules in modules. But that's primarily for
> > testing purpose. I don't really see what you are hoping to achieve here.
>
> In practice, these sample modules are very useful for
> developing/debugging the OpenGL filters "engine".
>
> Of course, I could keep them only locally on my computer (during
> development, I just put them in `modules/video_output/opengl/filters`),
> but I think it would be useful for other developers if it was possible
> to enable them easily (typically, with a simple --enable-samples flag).
>
> > If you want to demonstrate how to build a custom module, then you're better off
> > creating a separate git tree with a working standalone build system. Sample
> > LibVLC applications under docs are fine; third party developers will just copy
> > some of the code. But I really don't see the point for modules where it's
> > nowhere near that simple.
> >
> > --
> > Реми Дёни-Курмон
> > http://www.remlab.net/
> >
> >
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel