[vlc-devel] [PATCH 05/27] opengl: store video format in sampler

[Rémi Denis-Courmont]

Le maanantaina 29. kesäkuuta 2020, 17.05.23 EEST Romain Vimont a écrit :
> The line below, I set p_palette to NULL because we don't use it. But
> yes, it's hacky.

It's not hacky. What's hacky is to have a palette in video_format_t.

> It was to avoid video_format_Copy() (which imposes error handling).

It's about time we stop treating palettized pixmaps as decoded images, 
actually decode the palette in the decoder and *not* have a palette field in 
the video format.

The year is not 1990.

There are exactly one video decoder that can output palettized RGB, avcodec, 
and zero that can output YUVP (YUVP is only valid for SPU).

And then video_format_Copy() cannot fail any longer.

-- 
レミ・デニ-クールモン
http://www.remlab.net/