[vlc-devel] [PATCH 08/27] opengl: load filters from command-line arguments

Romain Vimont rom1v at videolabs.io
Mon Jun 29 17:20:12 CEST 2020


On Mon, Jun 29, 2020 at 04:47:34PM +0300, Rémi Denis-Courmont wrote:
> Le torstaina 25. kesäkuuta 2020, 15.22.55 EEST Romain Vimont a écrit :
> > Enable OpenGL filters via the --gl-filters command-line option:
> > 
> >     vlc file.mkv --gl-filters=filter1:filter2
> 
> IMO, this is a bad idea at this point.
> 
> That's the kind of option that people would grow to expect "just works", and 
> then just breaks with a VLC update because the default output is no longer 
> OpenGL. Say Vulkan.

Indeed, I would prefer --vout='opengl{filters=filter1:filter2}' instead.
But currently, it seems we can't pass parameters that way for vout. I
could try to change it if it's acceptable.

> In fact, it's rather bizarre to invest so much effort on a sunset technology.

Yes, but it's not dead yet ;)

> This is further aggravated by the lack of filters when passing video through 
> from the hardware decoder to OpenGL. Users would learn the wrong habit of 
> using --gl-filter=deinterlace,adjust instead of the normal existing filter 
> syntax.

This patchset is just a first step: executing OpenGL filters in the
vout. It's simpler because we already have the OpenGL context, and we
can directly draw.

After that, with Alexandre we have WIP to execute OpenGL filters as
video_filter_t, and more WIP to execute deinterlace filters with
--deinterlace-mode=my_opengl_deinterlace_filter.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list