[vlc-devel] [PATCH 17/27] opengl: pass picture PTS to filters

[Romain Vimont]

On Mon, Jun 29, 2020 at 04:42:27PM +0300, Rémi Denis-Courmont wrote:
> Le maanantaina 29. kesäkuuta 2020, 16.32.58 EEST Alexandre Janniaux a écrit :
> > Hi,
> > 
> > This need to be more precise, PTS could mean different things here.
> 
> Yes.
> 
> > Mentionning that it's the date associated to the input picture seems
> > more generic for the future case of OpenGL filter in the filter chain
> > pipeline and more precise to understand where the value comes from.
> 
> Even that's too vague. Do you mean the original PTS or the intended play time?

This PTS is just a copy of the ->date of the imported picture_t.

> And unless you are ready to handle asynchronous filters and rate changing 
> filters, exposing the date is rather questionable.

We could imaging a (stupid) filter which rotates a logo at a certain
rate (1 revolution every 10 seconds for example).

> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel