[vlc-devel] [PATCH] package/win32: build.sh: set VLC_TOOLS to the path we built them

Steve Lhomme robux4 at ycbcr.xyz
Mon Mar 2 08:55:29 CET 2020


On 2020-03-01 18:02, Alexandre Janniaux wrote:
> Hi,
> 
> On Sat, Feb 29, 2020 at 03:04:31PM +0100, Steve Lhomme wrote:
>> By default it will be $(TOPSRC)/../extras/tools/build which is not correct when
>> building out of tree.
>>
>> Not sure it's worth to check if we need to check if it was forced by the
>> environment.
>> ---
>>   extras/package/win32/build.sh | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/extras/package/win32/build.sh b/extras/package/win32/build.sh
>> index 6d782adf0d..985c6a3d4b 100755
>> --- a/extras/package/win32/build.sh
>> +++ b/extras/package/win32/build.sh
>> @@ -109,6 +109,7 @@ fi
>>   info "Building extra tools"
>>   mkdir -p extras/tools
>>   cd extras/tools
>> +export VLC_TOOLS="$PWD/extra/tools"
> 
> You mean "$PWD" alone right ?

Ah yes, it's after the cd. Also it should contain /build so it 
corresponds to where the bin folder is available.

>>
>>   export PATH="$PWD/build/bin":"$PATH"
>>   # Force patched meson as newer versions don't add -lpthread properly in libplacebo.pc
>> --
>> 2.18.0
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list