[vlc-devel] [PATCH 1/2] apple: build: use VLC_SRC_DIR

[Marvin Scholz]

Hi,

On 27 Feb 2020, at 21:33, Alexandre Janniaux wrote:

> The script might be used from any place and is not bound to use the 
> same
> file hierarchy as VLCKit.
> ---
>  extras/package/apple/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/extras/package/apple/build.sh 
> b/extras/package/apple/build.sh
> index 978871a6db..e334490c39 100755
> --- a/extras/package/apple/build.sh
> +++ b/extras/package/apple/build.sh
> @@ -630,7 +630,7 @@ cd "${VLC_BUILD_DIR}/build" || abort_err "Failed 
> cd to VLC build dir"
>  # Create VLC install dir if it does not already exist
>  mkdir -p "$VLC_INSTALL_DIR"
>
> -../../configure \
> +${VLC_SRC_DIR}/configure \

This change does not seem to matter though, as previously the script
does:

   cd "${VLC_BUILD_DIR}/build" || abort_err "Failed cd to VLC build dir"

so we are always in the script build dir so ../../configure always 
exists.

If you want to change this requirement you would at least need to change
this check too:

   # Verify script run location
   [ ! -f "$(pwd)/../src/libvlc.h" ] \
       && echo "ERROR: This script must be run from a" \
               "build subdirectory in the VLC source" >&2 \
       && exit 1

and possibly other paths in the script, as it was not written to be run
from anywhere.

Can you elaborate in which case you need this patch please, as I fail to
see how it makes a difference?

>      --with-contrib="$VLC_CONTRIB_INSTALL_DIR" \
>      --host="$VLC_HOST_TRIPLET" \
>      --prefix="$VLC_INSTALL_DIR" \
> -- 
> 2.25.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel