[vlc-devel] [PATCH] dshow: add mapping for H264 subtypes

Steve Lhomme robux4 at ycbcr.xyz
Mon Mar 2 14:04:04 CET 2020


LGTM.

It compiles for me. I hope it will on our bots as well as they may use 
older mingw64 versions which may not have these values (added 5 years 
ago in mingw64).

On 2020-02-17 16:49, Dmitry Buzdyk wrote:
> Map H264 subtypes containing H264 bitstream in Annex B format to VLC_CODEC_H264
> https://docs.microsoft.com/en-us/windows/win32/directshow/h-264-video-types
> 
> ---
>   modules/access/dshow/filter.cpp | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/modules/access/dshow/filter.cpp b/modules/access/dshow/filter.cpp
> index 0c23e50a5e..86aac85c08 100644
> --- a/modules/access/dshow/filter.cpp
> +++ b/modules/access/dshow/filter.cpp
> @@ -178,6 +178,12 @@ int GetFourCCFromMediaType( const AM_MEDIA_TYPE &media_type )
>               else if( media_type.subtype == MEDIASUBTYPE_MJPG )
>                   i_fourcc = VLC_CODEC_MJPG;
>   
> +            else if ( media_type.subtype == MEDIASUBTYPE_H264 ||
> +                      media_type.subtype == MEDIASUBTYPE_h264 ||
> +                      media_type.subtype == MEDIASUBTYPE_x264 ||
> +                      media_type.subtype == MEDIASUBTYPE_X264 )
> +                i_fourcc = VLC_CODEC_H264;
> +
>           }
>       }
>       else if( media_type.majortype == MEDIATYPE_Audio )
> -- 
> 2.25.0
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list