[vlc-devel] [PATCH] vout: vout_DisableWindow should not release video decoder device

Steve Lhomme robux4 at ycbcr.xyz
Mon Mar 2 14:15:05 CET 2020


LGTM.

Now we can create a decoder device on a disabled (or not yet enabled) 
window so we don't need to match the destruction with the enable/disable 
of the window.

On 2020-03-02 13:00, Thomas Guillem wrote:
> Ok for me.
> 
> Steve ?
> 
> On Mon, Mar 2, 2020, at 10:52, quentin.chateau at deepskycorp.com wrote:
>> From: Quentin Chateau <quentin.chateau at deepskycorp.com>
>>
>> ---
>>   src/video_output/video_output.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
>> index 229b010a96..a711d302af 100644
>> --- a/src/video_output/video_output.c
>> +++ b/src/video_output/video_output.c
>> @@ -1786,11 +1786,6 @@ static void vout_DisableWindow(vout_thread_t *vout)
>>   {
>>       vout_thread_sys_t *sys = vout->p;
>>       vlc_mutex_lock(&sys->window_lock);
>> -    if (sys->dec_device)
>> -    {
>> -        vlc_decoder_device_Release(sys->dec_device);
>> -        sys->dec_device = NULL;
>> -    }
>>       if (sys->window_enabled) {
>>           vout_window_Disable(sys->display_cfg.window);
>>           sys->window_enabled = false;
>> -- 
>> 2.17.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list