[vlc-devel] [PATCH 1/2] aout: use vlc_atomic_rc_t

[Thomas Guillem]

Yes for me.

On Tue, Mar 3, 2020, at 11:23, Quentin Chateau wrote:
> Now that the helpers have been fixed, does this patchset look good to you ?

> On 21/02/2020 21:13, Quentin Chateau wrote:
>> Would fixing the generic helper by replacing the uint by a uintptr be enough ? That would fix all other parts of VLC using them at the same time.
>> On Feb 21, 2020, at 20:06, "Rémi Denis-Courmont" <remi at remlab.net> wrote: 
>>> Le perjantaina 21. helmikuuta 2020, 19.32.24 EET Quentin Chateau a écrit :
>>> 
>>>>  I fail to see what you mean, can you please give me some more info so I
 can meet your expectations:
 
  1. Are you afraid of the counter overflowing the underlying unsigned int ?
>>>> 
>>> 
Yes.

>>> 
>>>>   2. How is it worse than before ?
>>>> 
>>> 
This has already been discussed before. You can overflow uint on a 64-bits 
platform. There's already been exploits on other programs doing exactly that. 
You can't overflow uintptr_t since you can't have that many references in a 
single address space (and it would take forever).

>>> 
>>>>   3. What's the point of having helper functions for reference counting
     if we should not use them ?
>>>> 
>>> 
Don't ask me. They're pointless as far as I can see.
>>> 
>> 
>> _______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200303/65a1bfc9/attachment.html>