[vlc-devel] [PATCH 2/2] configure: split dynamic plugins from dynamic loader

[Alexandre Janniaux]

Hi,

On Fri, Mar 06, 2020 at 04:24:11PM +0200, Remi Denis-Courmont wrote:
> Le 2020-03-05 20:25, Alexandre Janniaux a écrit :
> > As we can embed static and dynamic plugins at the same time, it makes
> > sense to build LibVLC-provided modules inside VLC but still allow
> > external out-of-tree plugins to be added later.
>
> We can't do that with the current system. Dynamic loading will fail
> miserably at run-time if you build libvlccore statically. And even if we
> could, this patch is just gratuitously renaming.

What do you mean? There is no error path on the dynamic
loading of modules and it seems to works for me. The major
pain point is the different handling between static and
dynamic plugins, but static ones are already tagged as
unloadable and excluded from the concerned functions.

It's not a gratuitously renaming btw, the HAVE_DYNAMIC_PLUGINS
is still existing, but will be different from the other
HAVE_DYNAMIC_LOADER. I can do the reverse if you have better
name but HAVE_DYNAMIC_PLUGIN to tell «we're building the core
plugins as dynamic plugins» and HAVE_DYNAMIC_LOADER for
«we're enabling the dynamic loader in libvlccore» seemed to
make sense to me.

Regards,
--
Alexandre Janniaux
Videolabs