[vlc-devel] [PATCH 2/2] configure: split dynamic plugins from dynamic loader

[Alexandre Janniaux]

Hi,

On Fri, Mar 06, 2020 at 05:35:55PM +0200, Remi Denis-Courmont wrote:
> Le 2020-03-06 17:04, Alexandre Janniaux a écrit :
> > > We can't do that with the current system. Dynamic loading will fail
> > > miserably at run-time if you build libvlccore statically. And even
> > > if we
> > > could, this patch is just gratuitously renaming.
> >
> > What do you mean?
>
> I mean exactly what I wrote. Dynamically loading plugins will fail if
> libvlccore is not a shared object.

Right, but that's a matter of how and for which target you
link libvlccore. And it only matters for plugins actually
using libvlccore function.

>
> > It's not a gratuitously renaming btw, the HAVE_DYNAMIC_PLUGINS
> > is still existing, but will be different from the other
> > HAVE_DYNAMIC_LOADER. I can do the reverse if you have better
> > name but HAVE_DYNAMIC_PLUGIN to tell «we're building the core
> > plugins as dynamic plugins» and HAVE_DYNAMIC_LOADER for
> > «we're enabling the dynamic loader in libvlccore» seemed to
> > make sense to me.
>
> You can't load dynamic plugins without the dynamic loader, and you can't use
> the dynamic loader without dynamic plugins to load with it.

Yes, you can use out-of-tree plugins, which is the whole
point of this split.

Regards,
--
Alexandre Janniaux
Videolabs