[vlc-devel] [PATCH 2/2] configure: split dynamic plugins from dynamic loader

[Remi Denis-Courmont]

Le 2020-03-06 17:04, Alexandre Janniaux a écrit :
> What do you mean? There is no error path on the dynamic
> loading of modules and it seems to works for me.

I mean exactly what I wrote: with the current system, dynamically 
loading a plugin *will* fail at run-time (if not at linking time) if 
libvlccore is not a shared object.

You can have static plugins in a dynamic build, using the weak symbol, 
but not the other way around.

> It's not a gratuitously renaming btw, the HAVE_DYNAMIC_PLUGINS
> is still existing, but will be different from the other
> HAVE_DYNAMIC_LOADER. I can do the reverse if you have better
> name but HAVE_DYNAMIC_PLUGIN to tell «we're building the core
> plugins as dynamic plugins» and HAVE_DYNAMIC_LOADER for
> «we're enabling the dynamic loader in libvlccore» seemed to
> make sense to me.

You can't load dynamic plugins without the dynamic loader, and you can't 
use the dynamic loader without dynamic plugins to load with it. With 
that, I don't see how it's not gratuitous to make a distinction.

-- 
Rémi Denis-Courmont