[vlc-devel] [PATCH] vlc_fixups: allow overriding the minimum Windows SDK for certain files

[Remi Denis-Courmont]

Le 2020-03-06 17:06, Steve Lhomme a écrit :
>> I don't see how that would actually work. <vlc_fixups.h> could end up 
>> defining stuff which conflicts with newer Windows versions and the 
>> build would fail.
> 
> We have never had the case so far and since at least 3.0 we compile
> some C file with a different _WIN32_WINNT than the project one.

IIRC, it did happen in the past. But anyway, I don't think we should be 
defining a custom way to set the Windows version. That will cause 
confusion and problems sooner or later.

Just define the version before you include config.h if that's what you 
need. The current #undef style is anyway invalid, as you're not supposed 
to be able to change the version half-way through your #include's.

> In 4.0 it's currently not an issue, we don't support anything older
> than Win7 so all of these defines have actually no effect. The idea
> here is to have a common way to do it so it can be backported to 3.0.

I don't think we should be making potentially dangerous changes to the 
build system in 3.0 at this point.


-- 
Rémi Denis-Courmont