[vlc-devel] [PATCH] es_out: use sout control only when sout is enabled

[Thomas Guillem]

It raises a question:
Should we remove ENABLE_SOUT defines in core ? I don't think we gain a lot of binary size with this optim.
The most important is to disable sout modules compilation.

Otherwise, LGTM.

On Tue, Mar 10, 2020, at 00:12, Alexandre Janniaux wrote:
> sout_instance_ControlsPace implementation is only compiled when
> ENABLE_SOUT is defined, so es_out should only use it in that case.
> ---
>  src/input/es_out.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/input/es_out.c b/src/input/es_out.c
> index 118c780c95..e4e0e460ac 100644
> --- a/src/input/es_out.c
> +++ b/src/input/es_out.c
> @@ -2752,6 +2752,7 @@ static int EsOutSend( es_out_t *out, es_out_id_t 
> *es, block_t *p_block )
>          return VLC_SUCCESS;
>      }
>  
> +#ifdef ENABLE_SOUT
>      /* Check for sout mode */
>      if( input_priv(p_input)->p_sout )
>      {
> @@ -2762,6 +2763,7 @@ static int EsOutSend( es_out_t *out, es_out_id_t 
> *es, block_t *p_block )
>  
>          input_priv(p_input)->b_out_pace_control = pace;
>      }
> +#endif
>  
>      /* Decode */
>      if( es->p_dec_record )
> -- 
> 2.25.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel